Return-path: Received: from smtprelay0108.hostedemail.com ([216.40.44.108]:40356 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751581AbaCHB4y (ORCPT ); Fri, 7 Mar 2014 20:56:54 -0500 Message-ID: <1394243809.6972.4.camel@joe-AO722> (sfid-20140308_025657_831138_DAE03E84) Subject: Re: [PATCH v2] mac80211: LLVMLinux: Remove VLAIS usage from mac80211 From: Joe Perches To: behanw@converseincode.com Cc: linville@tuxdriver.com, johannes@sipsolutions.net, davem@davemloft.net, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, dwmw2@infradead.org, pageexec@freemail.hu, Jan-Simon =?ISO-8859-1?Q?M=F6ller?= , =?ISO-8859-1?Q?Vin=EDcius?= Tinti , Mark Charlebois Date: Fri, 07 Mar 2014 17:56:49 -0800 In-Reply-To: <1394241960-1764-1-git-send-email-behanw@converseincode.com> References: <1394177091.4653.1.camel@jlt4.sipsolutions.net> <1394241960-1764-1-git-send-email-behanw@converseincode.com> Content-Type: text/plain; charset="ISO-8859-1" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Fri, 2014-03-07 at 17:26 -0800, behanw@converseincode.com wrote: > From: Jan-Simon M?ller > > Replaced the use of a Variable Length Array In Struct (VLAIS) with a C99 > compliant equivalent. This is the original VLAIS struct. [] > diff --git a/net/mac80211/aes_ccm.c b/net/mac80211/aes_ccm.c [] > @@ -23,12 +23,14 @@ void ieee80211_aes_ccm_encrypt(struct crypto_aead *tfm, u8 *b_0, u8 *aad, > u8 *data, size_t data_len, u8 *mic) > { > struct scatterlist assoc, pt, ct[2]; > - struct { > - struct aead_request req; > - u8 priv[crypto_aead_reqsize(tfm)]; > - } aead_req; > > - memset(&aead_req, 0, sizeof(aead_req)); > + char aead_req_data[sizeof(struct aead_request) + > + crypto_aead_reqsize(tfm) + > + CRYPTO_MINALIGN] CRYPTO_MINALIGN_ATTR; Can this be a too large amount of stack? Is crypto_aead_reqsize() limited to < ~1k? Perhaps it'd be better to use kzalloc for this or another reserved pool