MIME-Version: 1.0
In-Reply-To: <87siq2v1lm.fsf@kamboji.qca.qualcomm.com>
References: <20140328132849.31620.78501.stgit@potku.adurom.net>
	<CA+BoTQmqf8kryKEeD00P6o+N7C+980pEqHnT9qe4H4cjZ+eb=w@mail.gmail.com>
	<87wqfev2ml.fsf@kamboji.qca.qualcomm.com>
	<CAEFj985Xq-_QRmdOsFKEM0kA40TpgKL6t1DW8yXSPY6dn=R2LA@mail.gmail.com>
	<87siq2v1lm.fsf@kamboji.qca.qualcomm.com>
Date: Sat, 29 Mar 2014 00:07:24 +0800
Message-ID: <CAEFj9848WTRBMNDGZAsN3DZa757bGMsO5dC0jTY+DCCJsYV_5Q@mail.gmail.com> (sfid-20140328_170732_764604_36064963)
Subject: Re: [PATCH v5] ath10k: implement per-VDEV FW statistics
From: Yeoh Chun-Yeow <yeohchunyeow@gmail.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: Michal Kazior <michal.kazior@tieto.com>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-wireless-owner@vger.kernel.org

So this patch is intended for firmware 999.999.0.716, right?

---
Chun-Yeow

On Fri, Mar 28, 2014 at 10:28 PM, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
> Yeoh Chun-Yeow <yeohchunyeow@gmail.com> writes:
>
>> On Fri, Mar 28, 2014 at 10:06 PM, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
>>> Michal Kazior <michal.kazior@tieto.com> writes:
>>>
>>>> On 28 March 2014 14:28, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
>>>>> From: Bartosz Markowski <bartosz.markowski@tieto.com>
>>>>>
>>>>> The WMI_REQUEST_PEER_STAT command with latest (999.999.0.716) FW
>>>>> can return per-VDEV statistics. Using debugfs we can fetch this info now.
>>>>>
>>>>> This is a backward compatible change. In case of older FW the VDEV
>>>>> statistics are simply not returned.
>>>>>
>>>>> kvalo: remove struct wmi_peer_stats_common cast from
>>>>> ath10k_debug_read_target_stats()
>>>>
>>>> I just glanced over the patch and I don't think this is correct.
>>>>
>>>> Firmware 10.1.467 has peer_rx_rate but doesn't seem to have vdev stats.
>>>
>>> Ok, I need to take a closer look at this. If someone else wants to look
>>> at this instead, feel free to do that :)
>>>
>> I up two AP interfaces in same physical but not able to see two
>> different vdev in get stats.
>
> That's because the firmware image have doesn't have the feature bit set.
>
> --
> Kalle Valo