Return-path: Received: from r00tworld.com ([212.85.137.150]:52833 "EHLO r00tworld.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751897AbaCHWqx (ORCPT ); Sat, 8 Mar 2014 17:46:53 -0500 From: "PaX Team" To: behanw@converseincode.com, Sergei Antonov Date: Sat, 08 Mar 2014 23:01:48 +0100 MIME-Version: 1.0 Subject: Re: [PATCH v2] mac80211: LLVMLinux: Remove VLAIS usage from mac80211 Reply-to: pageexec@freemail.hu CC: linville@tuxdriver.com, johannes@sipsolutions.net, davem@davemloft.net, linux-wireless , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, dwmw2@infradead.org, "=?UTF-8?Q?Jan-Simon_M=C3=B6ller?=" , "=?UTF-8?Q?Vin=C3=ADcius_Tinti?=" , Mark Charlebois Message-ID: <531B934C.31666.37555A14@pageexec.freemail.hu> (sfid-20140308_234701_465191_0489C1EC) In-reply-to: References: <1394177091.4653.1.camel@jlt4.sipsolutions.net>, <1394241960-1764-1-git-send-email-behanw@converseincode.com>, Content-type: text/plain; charset=US-ASCII Sender: linux-wireless-owner@vger.kernel.org List-ID: On 8 Mar 2014 at 21:29, Sergei Antonov wrote: > > - memset(&aead_req, 0, sizeof(aead_req)); > > + char aead_req_data[sizeof(struct aead_request) + > > + crypto_aead_reqsize(tfm) + > > + CRYPTO_MINALIGN] CRYPTO_MINALIGN_ATTR; ^^^^^^^^^^^^^^^^^^^^ wouldn't the underlined attribute ensure the required alignment? > Bad trick with regards to alignment. > The alignment requirement for struct aead_request is stronger than > what an array of chars may have.