Return-path: Received: from mail-wg0-f52.google.com ([74.125.82.52]:60456 "EHLO mail-wg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753286AbaCaMKf (ORCPT ); Mon, 31 Mar 2014 08:10:35 -0400 Received: by mail-wg0-f52.google.com with SMTP id k14so5693988wgh.23 for ; Mon, 31 Mar 2014 05:10:34 -0700 (PDT) From: Michal Kazior To: linux-wireless@vger.kernel.org Cc: johannes@sipsolutions.net, Michal Kazior Subject: [PATCH v3 5/5] cfg80211: remove channel_switch combination check Date: Mon, 31 Mar 2014 14:04:19 +0200 Message-Id: <1396267459-9976-6-git-send-email-michal.kazior@tieto.com> (sfid-20140331_141051_091111_1AAD5E37) In-Reply-To: <1396267459-9976-1-git-send-email-michal.kazior@tieto.com> References: <1395409941-26303-1-git-send-email-michal.kazior@tieto.com> <1396267459-9976-1-git-send-email-michal.kazior@tieto.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: Make the driver responsible for making sure it is capable of performing the switch. It might as well accept a request but then disconnect an interface if some requirements are not met. In that case userspace should be prepared for an appropriate event (AP/IBSS/mesh being stopped/left). Signed-off-by: Michal Kazior --- net/wireless/nl80211.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index 232d15c..84aeb80 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c @@ -5932,17 +5932,6 @@ skip_beacons: params.radar_required = true; } - /* TODO: I left this here for now. With channel switch, the - * verification is a bit more complicated, because we only do - * it later when the channel switch really happens. - */ - err = cfg80211_can_use_iftype_chan(rdev, wdev, wdev->iftype, - params.chandef.chan, - CHAN_MODE_SHARED, - radar_detect_width); - if (err) - return err; - if (info->attrs[NL80211_ATTR_CH_SWITCH_BLOCK_TX]) params.block_tx = true; -- 1.8.5.3