Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:5731 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751227AbaC1OGr (ORCPT ); Fri, 28 Mar 2014 10:06:47 -0400 From: Kalle Valo To: Michal Kazior CC: linux-wireless , "ath10k@lists.infradead.org" Subject: Re: [PATCH v5] ath10k: implement per-VDEV FW statistics References: <20140328132849.31620.78501.stgit@potku.adurom.net> Date: Fri, 28 Mar 2014 16:06:42 +0200 In-Reply-To: (Michal Kazior's message of "Fri, 28 Mar 2014 14:53:40 +0100") Message-ID: <87wqfev2ml.fsf@kamboji.qca.qualcomm.com> (sfid-20140328_150651_098124_B70C72E5) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-wireless-owner@vger.kernel.org List-ID: Michal Kazior writes: > On 28 March 2014 14:28, Kalle Valo wrote: >> From: Bartosz Markowski >> >> The WMI_REQUEST_PEER_STAT command with latest (999.999.0.716) FW >> can return per-VDEV statistics. Using debugfs we can fetch this info now. >> >> This is a backward compatible change. In case of older FW the VDEV >> statistics are simply not returned. >> >> kvalo: remove struct wmi_peer_stats_common cast from >> ath10k_debug_read_target_stats() > > I just glanced over the patch and I don't think this is correct. > > Firmware 10.1.467 has peer_rx_rate but doesn't seem to have vdev stats. Ok, I need to take a closer look at this. If someone else wants to look at this instead, feel free to do that :) -- Kalle Valo