Return-path: Received: from mail-pa0-f42.google.com ([209.85.220.42]:46550 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750747AbaDJGNl (ORCPT ); Thu, 10 Apr 2014 02:13:41 -0400 Received: by mail-pa0-f42.google.com with SMTP id fb1so3552408pad.29 for ; Wed, 09 Apr 2014 23:13:41 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1397071009.4964.18.camel@jlt4.sipsolutions.net> References: <1393376982-28276-1-git-send-email-mcgrof@do-not-panic.com> <1393376982-28276-3-git-send-email-mcgrof@do-not-panic.com> <1393852248.10039.5.camel@jlt4.sipsolutions.net> <1397071009.4964.18.camel@jlt4.sipsolutions.net> From: Arik Nemtsov Date: Thu, 10 Apr 2014 09:13:26 +0300 Message-ID: (sfid-20140410_081345_481120_6ECC1FF0) Subject: Re: [PATCH 2/3] cfg80211: fix processing world regdomain when non modular To: Johannes Berg Cc: Colleen T , "Luis R. Rodriguez" , Janusz Dziedzic , linux-wireless , Sander Eikelenboom Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, Apr 9, 2014 at 10:16 PM, Johannes Berg wrote: > +static void reg_free_last_request(struct regulatory_request *lr) > > Isn't it odd to pass the last request to a function called > reg_free_last_request()? > It makes sense to me. Non-last requests are freed using kfree. The last request needs RCU. Arik