Return-path: Received: from mail-pa0-f47.google.com ([209.85.220.47]:40843 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753357AbaDBHzf (ORCPT ); Wed, 2 Apr 2014 03:55:35 -0400 From: Daeseok Youn To: davem@davemloft.net, lauro.venancio@openbossa.org Cc: aloisio.almeida@openbossa.org, sameo@linux.intel.com, linux-wireless@vger.kernel.org, linux-nfc@lists.01.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] nfc: fix NULL pointer dereference Date: Wed, 02 Apr 2014 16:55:30 +0900 Message-ID: <20540404.Au0OUqzobS@daeseok-laptop.cloud.net> (sfid-20140402_095617_905631_80FEE61B) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-wireless-owner@vger.kernel.org List-ID: dev is NULL when nfc_get_device() is failed but dev is used for handling error. coccicheck says: net/nfc/netlink.c:1092:21-24: ERROR: dev is NULL but dereferenced. Signed-off-by: Daeseok Youn --- net/nfc/netlink.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/net/nfc/netlink.c b/net/nfc/netlink.c index 43cb1c1..b2ad570 100644 --- a/net/nfc/netlink.c +++ b/net/nfc/netlink.c @@ -1026,10 +1026,8 @@ static int nfc_genl_llc_sdreq(struct sk_buff *skb, struct genl_info *info) idx = nla_get_u32(info->attrs[NFC_ATTR_DEVICE_INDEX]); dev = nfc_get_device(idx); - if (!dev) { - rc = -ENODEV; - goto exit; - } + if (!dev) + return -ENODEV; device_lock(&dev->dev); -- 1.7.4.4