Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:38087 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933342AbaDIOI4 (ORCPT ); Wed, 9 Apr 2014 10:08:56 -0400 From: Vladimir Kondratiev To: Joe Perches CC: "John W . Linville" , , , netdev Subject: Re: [PATCH 1/5] wil6210: Convert to Kbuild Date: Wed, 9 Apr 2014 17:08:49 +0300 Message-ID: <2146187.nt2BTDzSlP@lx-vladimir> (sfid-20140409_161021_674592_E5296C12) In-Reply-To: <1396973691.5212.3.camel@joe-AO722> References: <1396946179-11677-1-git-send-email-qca_vkondrat@qca.qualcomm.com> <1396946179-11677-2-git-send-email-qca_vkondrat@qca.qualcomm.com> <1396973691.5212.3.camel@joe-AO722> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tuesday, April 08, 2014 09:14:51 AM Joe Perches wrote: > On Tue, 2014-04-08 at 11:36 +0300, Vladimir Kondratiev wrote: > > Convert Makefile -> Kbuild, > > to make off-kernel development easier and less intrusive. > > No drivers/net directory uses Kbuild. > > Why should this? because it makes it easier to do off-kernel development, and then move things to the proper location within the kernel without conflicting changes in the Makefile. As I understand, Kbuild is better choice because it is really not standalone "Makefile", it is intended to be included by the real Makefile. Thus, distinct name is better. Are there any reasons why not using Kbuild? I did not found guidelines when use Kbuild and when not. > > > Signed-off-by: Vladimir Kondratiev > > --- > > drivers/net/wireless/ath/wil6210/Kbuild | 18 ++++++++++++++++++ > > drivers/net/wireless/ath/wil6210/Makefile | 18 ------------------ > > If you send renaming patches, please use > git format-patch -M Sure I will. Thanks for mentioning this. Thanks, Vladimir