Return-path: Received: from mail-pa0-f51.google.com ([209.85.220.51]:35849 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965070AbaDJIRk (ORCPT ); Thu, 10 Apr 2014 04:17:40 -0400 Received: by mail-pa0-f51.google.com with SMTP id kq14so3662229pab.38 for ; Thu, 10 Apr 2014 01:17:40 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1397116902.4757.6.camel@jlt4.sipsolutions.net> References: <1393376982-28276-1-git-send-email-mcgrof@do-not-panic.com> <1393376982-28276-3-git-send-email-mcgrof@do-not-panic.com> <1393852248.10039.5.camel@jlt4.sipsolutions.net> <1397071009.4964.18.camel@jlt4.sipsolutions.net> <1397116902.4757.6.camel@jlt4.sipsolutions.net> From: Arik Nemtsov Date: Thu, 10 Apr 2014 11:17:24 +0300 Message-ID: (sfid-20140410_101746_559796_42FA4670) Subject: Re: [PATCH 2/3] cfg80211: fix processing world regdomain when non modular To: Johannes Berg Cc: Colleen T , "Luis R. Rodriguez" , Janusz Dziedzic , linux-wireless , Sander Eikelenboom Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, Apr 10, 2014 at 11:01 AM, Johannes Berg wrote: > On Thu, 2014-04-10 at 09:13 +0300, Arik Nemtsov wrote: >> On Wed, Apr 9, 2014 at 10:16 PM, Johannes Berg >> wrote: >> > +static void reg_free_last_request(struct regulatory_request *lr) >> > >> > Isn't it odd to pass the last request to a function called >> > reg_free_last_request()? >> > >> >> It makes sense to me. Non-last requests are freed using kfree. The >> last request needs RCU. > > Yeah but there can only be one "last request", so why pass it? oh. well that was weird before as well. :) let's wait to see if it solves the bug? I can respin it without the arg later. Arik