Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:57369 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752350AbaEUSP0 (ORCPT ); Wed, 21 May 2014 14:15:26 -0400 Date: Wed, 21 May 2014 14:00:21 -0400 From: "John W. Linville" To: Johannes Berg Cc: "Luis R. Rodriguez" , Janusz Dziedzic , "wireless-regdb@lists.infradead.org" , linux-wireless Subject: Re: [PATCH] wireless-regdb: add DFS CAC time parameter Message-ID: <20140521180020.GA13656@tuxdriver.com> (sfid-20140521_201529_758384_A7477342) References: <1399624824-9204-1-git-send-email-janusz.dziedzic@tieto.com> <20140520142453.GB13981@tuxdriver.com> <20140520180832.GD13981@tuxdriver.com> <1400610273.4474.6.camel@jlt4.sipsolutions.net> <1400688233.4136.8.camel@jlt4.sipsolutions.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1400688233.4136.8.camel@jlt4.sipsolutions.net> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, May 21, 2014 at 06:03:53PM +0200, Johannes Berg wrote: > On Tue, 2014-05-20 at 11:48 -0700, Luis R. Rodriguez wrote: > > > > I think we should, but if we can't then at least can we cut to an > > > extensible format? > > I don't see any way to extend the format right now. > > There's a wrinkle with making it more extensible too though - if we do > that then we must be extremely careful that future older crda versions > (i.e. the next version that we're about to write) will not parse a newer > extended file more permissively, so our extensions are limited anyway. > > Looks like the format update really is needed, which probably means we > should change the scripts to generate two databases and change the > filename, or so? The 'do not parse more permissively' would seem to be a problem if we still produce an older format too, no? I mean, wouldn't we have to simply drop new rules to produce an older binary? Even worse if we left the old binary in place, since then you could never update any rules for old crda installations at all. It seems like forcing a crda update to use any new format-breaking rules might just be the right thing. Can we make crda choke and die loudly when it sees an unknown format? Will the current crda do that? John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.