Return-path: Received: from mail-oa0-f49.google.com ([209.85.219.49]:57296 "EHLO mail-oa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932448AbaEEO4T (ORCPT ); Mon, 5 May 2014 10:56:19 -0400 Message-ID: <5367A690.7010305@lwfinger.net> (sfid-20140505_165628_379509_274F5FFD) Date: Mon, 05 May 2014 09:56:16 -0500 From: Larry Finger MIME-Version: 1.0 To: Adam Lee , linux-wireless@vger.kernel.org CC: netdev@vger.kernel.org, "John W. Linville" Subject: Re: [PATCH 1/3] rtlwifi: make MSI support a module parameter References: <1399278818-19152-1-git-send-email-adam.lee@canonical.com> In-Reply-To: <1399278818-19152-1-git-send-email-adam.lee@canonical.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 05/05/2014 03:33 AM, Adam Lee wrote: > This makes MSI support a module parameter, for debugging and workaround > convenience. > > Signed-off-by: Adam Lee Acked-by: Larry Finger (for all 3 patches) I would have made the default for the MSI option to be true, but that is a matter of preference, and only experience would show which default leads to the fewer failures. On my laptop, both rtl8188ee and rtl8723be work either way. I am now working on a driver for the RTL8192EE that also can use MSI - that has only been tested with the option on. Larry > --- > drivers/net/wireless/rtlwifi/wifi.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/net/wireless/rtlwifi/wifi.h b/drivers/net/wireless/rtlwifi/wifi.h > index 6965afd..eef93d1 100644 > --- a/drivers/net/wireless/rtlwifi/wifi.h > +++ b/drivers/net/wireless/rtlwifi/wifi.h > @@ -2030,6 +2030,10 @@ struct rtl_mod_params { > > /* default: 1 = using linked fw power save */ > bool fwctrl_lps; > + > + /* default: 0 = not using MSI interrupts mode */ > + /* submodules should set their own defalut value */ > + bool msi_support; > }; > > struct rtl_hal_usbint_cfg { >