Return-path: Received: from mail-pa0-f45.google.com ([209.85.220.45]:51389 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756958AbaEEWkl (ORCPT ); Mon, 5 May 2014 18:40:41 -0400 Received: by mail-pa0-f45.google.com with SMTP id ey11so5072936pad.18 for ; Mon, 05 May 2014 15:40:41 -0700 (PDT) Date: Mon, 5 May 2014 15:40:37 -0700 From: Stephen Hemminger To: Larry Finger Cc: Adam Lee , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, "John W. Linville" Subject: Re: [PATCH 1/3] rtlwifi: make MSI support a module parameter Message-ID: <20140505154037.19620ac2@nehalam.linuxnetplumber.net> (sfid-20140506_004049_895253_C4DD341B) In-Reply-To: <5367A690.7010305@lwfinger.net> References: <1399278818-19152-1-git-send-email-adam.lee@canonical.com> <5367A690.7010305@lwfinger.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, 05 May 2014 09:56:16 -0500 Larry Finger wrote: > On 05/05/2014 03:33 AM, Adam Lee wrote: > > This makes MSI support a module parameter, for debugging and workaround > > convenience. > > > > Signed-off-by: Adam Lee > > Acked-by: Larry Finger (for all 3 patches) > > I would have made the default for the MSI option to be true, but that is a > matter of preference, and only experience would show which default leads to the > fewer failures. On my laptop, both rtl8188ee and rtl8723be work either way. I am > now working on a driver for the RTL8192EE that also can use MSI - that has only > been tested with the option on. > > Larry Standard practice is to assume MSI is available, and let the quirks in the PCI subsystem reject the request to enable MSI. Also other drivers have a 'disable_msi' module parameter why not follow their example.