Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:49293 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756785AbaEPO0U (ORCPT ); Fri, 16 May 2014 10:26:20 -0400 From: Kalle Valo To: Luca Coelho CC: , , , Subject: Re: [PATCH] ath9k/ath10k: remove unnecessary channel_switch_beacon callbacks References: <1400248534-16763-1-git-send-email-luca@coelho.fi> Date: Fri, 16 May 2014 17:26:13 +0300 In-Reply-To: <1400248534-16763-1-git-send-email-luca@coelho.fi> (Luca Coelho's message of "Fri, 16 May 2014 16:55:34 +0300") Message-ID: <87y4y13im2.fsf@kamboji.qca.qualcomm.com> (sfid-20140516_162627_890778_69DD5806) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-wireless-owner@vger.kernel.org List-ID: Luca Coelho writes: > From: Luciano Coelho > > The channel_switch_beacon callback is optional, so it doesn't have to > be defined if it's not going to do anything useful with it. Both > ath9k and ath10k define the callback and just returns. This commit > removes them. > > Cc: Michal Kazior > Signed-off-by: Luciano Coelho > --- > > I'm plannnig to remove the channel_switch_beacon callback (actually, > replace it with a more generic one that can be used for STA and other > iftypes too) and ath9k/ath10k are the only (non) users of it. ;) John, I'm planning to take this as I think we will get less conflicts that way. But let me know if you want it instead. -- Kalle Valo