Return-path: Received: from mail-wg0-f49.google.com ([74.125.82.49]:40008 "EHLO mail-wg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753397AbaEMN4X (ORCPT ); Tue, 13 May 2014 09:56:23 -0400 Received: by mail-wg0-f49.google.com with SMTP id m15so415102wgh.8 for ; Tue, 13 May 2014 06:56:22 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1399988536.4137.23.camel@jlt4.sipsolutions.net> References: <1397050174-26121-14-git-send-email-michal.kazior@tieto.com> <1398849681-3606-1-git-send-email-michal.kazior@tieto.com> <1399372915.4218.17.camel@jlt4.sipsolutions.net> <1399385141.4218.37.camel@jlt4.sipsolutions.net> <1399450061.5038.10.camel@jlt4.sipsolutions.net> <1399455657.6800.4.camel@dubbel> <1399457760.6800.7.camel@dubbel> <1399460964.10517.12.camel@jlt4.sipsolutions.net> <1399463646.10517.28.camel@jlt4.sipsolutions.net> <1399464536.6800.11.camel@dubbel> <1399464789.10517.29.camel@jlt4.sipsolutions.net> <1399465244.6800.13.camel@dubbel> <1399466312.10517.34.camel@jlt4.sipsolutions.net> <1399467225.10517.35.camel@jlt4.sipsolutions.net> <1399543568.9163.5.camel@jlt4.sipsolutions.net> <1399988536.4137.23.camel@jlt4.sipsolutions.net> Date: Tue, 13 May 2014 15:56:22 +0200 Message-ID: (sfid-20140513_155627_100389_4331C0D3) Subject: Re: [PATCH v5] mac80211: implement multi-vif in-place reservations From: Michal Kazior To: Johannes Berg Cc: Luca Coelho , linux-wireless , Simon Wunderlich Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 13 May 2014 15:42, Johannes Berg wrote: > On Thu, 2014-05-08 at 12:41 +0200, Michal Kazior wrote: > >> Then, if you want to avoid the chanctx overcommit problem, you need to >> make switch_vif_chanctx() to act as drv_add_chanctx(old_ctx) and >> drv_remove_chanctx(new_ctx) implicitly, i.e. >> >> drv_switch_vif_chanctx(hw, vifs, n_vifs, old_ctx, new_ctx, SWAP); >> >> instead of: >> >> drv_add_chanctx(new_ctx); >> drv_switch_vif_chanctx(hw, vifs, n_vifs, old_ctx, new_ctx, SWAP); >> drv_remove_chanctx(old_ctx); > > That's pretty much what I'd considered, except that now as far as I read > the thread this wasn't sufficient for multi-context, so we'd need lists > of old/new contexts? Hmm.. In what cases do you need a list of old/new contexts? Michal