Return-path: Received: from mail-we0-f170.google.com ([74.125.82.170]:40570 "EHLO mail-we0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752998AbaE0QOg (ORCPT ); Tue, 27 May 2014 12:14:36 -0400 Message-ID: <5384B9E7.1070405@gmail.com> (sfid-20140527_181443_775505_1F04DE73) Date: Tue, 27 May 2014 18:14:31 +0200 From: Tomasz Figa MIME-Version: 1.0 To: Maxime Ripard , Hans de Goede CC: devicetree , Ulf Hansson , linux-wireless@vger.kernel.org, Linus Walleij , linux-sunxi@googlegroups.com, linux-mmc@vger.kernel.org, Chris Ball , "John W. Linville" , Chen-Yu Tsai , Arend van Spriel , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 02/11] pinctrl: sunxi: add IRQCHIP_SKIP_SET_WAKE flag for pinctrl irq chip References: <1401090486-4414-1-git-send-email-hdegoede@redhat.com> <1401090486-4414-3-git-send-email-hdegoede@redhat.com> <20140527080746.GB4730@lukather> In-Reply-To: <20140527080746.GB4730@lukather> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 27.05.2014 10:07, Maxime Ripard wrote: > On Mon, May 26, 2014 at 09:47:57AM +0200, Hans de Goede wrote: >> From: Chen-Yu Tsai >> >> The sunxi pinctrl irq chip driver does not support wakeup at the >> moment. Adding IRQCHIP_SKIP_SET_WAKE lets the irqs work with >> drivers using wakeup. >> >> Also add a name to the irq chip. >> >> Signed-off-by: Chen-Yu Tsai Signed-off-by: Hans >> de Goede --- >> drivers/pinctrl/sunxi/pinctrl-sunxi.c | 2 ++ 1 file changed, 2 >> insertions(+) >> >> diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.c >> b/drivers/pinctrl/sunxi/pinctrl-sunxi.c index db9ccd6..ec60c2e >> 100644 --- a/drivers/pinctrl/sunxi/pinctrl-sunxi.c +++ >> b/drivers/pinctrl/sunxi/pinctrl-sunxi.c @@ -646,6 +646,8 @@ >> static struct irq_chip sunxi_pinctrl_irq_chip = { .irq_mask_ack = >> sunxi_pinctrl_irq_mask_ack, .irq_unmask = >> sunxi_pinctrl_irq_unmask, .irq_set_type = >> sunxi_pinctrl_irq_set_type, + .name = "sunxi-pio", + .flags = >> IRQCHIP_SKIP_SET_WAKE, > > I'd rather see the name set to dev_name() or something like that. > This will not work that great with multiple pin controller > supporting interrupts. Correct me if I'm wrong, but I've always thought that struct irq_chip describes a class of IRQ controllers, not particular instances. Best regards, Tomasz