Return-path: Received: from lekensteyn.nl ([178.21.112.251]:60294 "EHLO lekensteyn.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751870AbaFWWaG (ORCPT ); Mon, 23 Jun 2014 18:30:06 -0400 From: Peter Wu To: Rickard Strandqvist Cc: Greg Kroah-Hartman , Larry Finger , Chaoming Li , Ben Hutchings , Mark Cave-Ayland , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [PATCHv3 6/6] drivers/staging/rtl8821ae: replace magic number by macro Date: Tue, 24 Jun 2014 00:29:54 +0200 Message-ID: <1455413.BevQxGKhmu@al> (sfid-20140624_003011_465147_6979B31C) In-Reply-To: <1403561511-8117-1-git-send-email-rickard_strandqvist@spectrumdigital.se> References: <1403561511-8117-1-git-send-email-rickard_strandqvist@spectrumdigital.se> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-wireless-owner@vger.kernel.org List-ID: (staging drivers are handled by Greg KH, cc'ing him) On Tuesday 24 June 2014 00:11:51 Rickard Strandqvist wrote: > For consistency with other drivers, replace a magic number by a macro. > > Signed-off-by: Rickard Strandqvist > Reviewed-by: Peter Wu > --- > drivers/staging/rtl8821ae/rtl8821ae/hw.c | 2 +- > drivers/staging/rtl8821ae/rtl8821ae/reg.h | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hw.c b/drivers/staging/rtl8821ae/rtl8821ae/hw.c > index 1b8583b..1aa1661 100644 > --- a/drivers/staging/rtl8821ae/rtl8821ae/hw.c > +++ b/drivers/staging/rtl8821ae/rtl8821ae/hw.c > @@ -1623,7 +1623,7 @@ static int _rtl8821ae_set_media_status(struct ieee80211_hw *hw, > > rtl_write_byte(rtlpriv, (MSR), bt_msr); > rtlpriv->cfg->ops->led_control(hw, ledaction); > - if ((bt_msr & ~0xfc) == MSR_AP) > + if ((bt_msr & MSR_MASK) == MSR_AP) > rtl_write_byte(rtlpriv, REG_BCNTCFG + 1, 0x00); > else > rtl_write_byte(rtlpriv, REG_BCNTCFG + 1, 0x66); > diff --git a/drivers/staging/rtl8821ae/rtl8821ae/reg.h b/drivers/staging/rtl8821ae/rtl8821ae/reg.h > index beffb42..4cb3ca9 100644 > --- a/drivers/staging/rtl8821ae/rtl8821ae/reg.h > +++ b/drivers/staging/rtl8821ae/rtl8821ae/reg.h > @@ -431,6 +431,7 @@ > #define MSR_ADHOC 0x01 > #define MSR_INFRA 0x02 > #define MSR_AP 0x03 > +#define MSR_MASK 0x03 > > #define RRSR_RSC_OFFSET 21 > #define RRSR_SHORT_OFFSET 23 >