Return-path: Received: from mail-pd0-f169.google.com ([209.85.192.169]:59951 "EHLO mail-pd0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750838AbaFXGJ5 (ORCPT ); Tue, 24 Jun 2014 02:09:57 -0400 Received: by mail-pd0-f169.google.com with SMTP id g10so6619202pdj.0 for ; Mon, 23 Jun 2014 23:09:57 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1402469724-22358-1-git-send-email-arik@wizery.com> <1402469724-22358-3-git-send-email-arik@wizery.com> <20140623182333.GB1390@garbanzo.do-not-panic.com> From: Arik Nemtsov Date: Tue, 24 Jun 2014 09:09:41 +0300 Message-ID: (sfid-20140624_081029_296686_A52CD87E) Subject: Re: [PATCH 3/5] cfg80211: treat the special "unknown" alpha2 as valid To: "Luis R. Rodriguez" Cc: linux-wireless Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, Jun 23, 2014 at 9:57 PM, Luis R. Rodriguez wrote: > On Mon, Jun 23, 2014 at 11:32 AM, Arik Nemtsov wrote: >>> modifieres for user_reg_hint_type, you'd want a driver_reg_hint_type, > > Minor note, since the driver reg hint type can be require the > regulatory data source to be internal to the driver (firmware or > driver, we won't know) and since the new API can allow the > driver/firmware to pass and let the request come from CRDA / > wireless-regdb / internal db the driver hint is different from the > final *set* regulatory domain. So for example although the goal was to > query firmware first if the driver passed and let the source of > regulatory data come from CRDA / wireless-regdb / internal regdb we'd > want to ensure userspace is informed of this. So I think we'd need a > regulatory data structure source type as well, right now it'd default > to wireless-regdb as the source (that would suffice for CRDA or > internal-db), and your changes would add an internal-driver source. Sure I can add a source to the regulatory_request structure. It will have something like CORE, CRDA, INTERNAL_REGDB, DRIVER. > > Since this is allowing drivers to be explicit about their regulatory > data it would be nice if as part of this we can then get 'iw reg get' > the ability to then spit out per wiphy regd. Since even the custom > regd requires passing a custom regd this could even enable parsing > that data as well. This should make trouble shooting for intersections > much easier on complex systems. This would have to wait a bit on my side. Arik