Return-path: Received: from mail-la0-f53.google.com ([209.85.215.53]:64619 "EHLO mail-la0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754425AbaF3TTa (ORCPT ); Mon, 30 Jun 2014 15:19:30 -0400 MIME-Version: 1.0 In-Reply-To: References: From: "Luis R. Rodriguez" Date: Mon, 30 Jun 2014 12:19:08 -0700 Message-ID: (sfid-20140630_211935_472010_241DC0C8) Subject: Re: Parser stable fix question for CFG80211_INTERNAL_REGDB To: linux-wireless , Johannes Berg , "John W. Linville" , Greg Kroah-Hartman , Felix Fietkau Cc: John Walker , Krishna Chaitanya , netfilter-devel@vger.kernel.org, Richard Fontana , "Luis R. Rodriguez" Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, Jun 30, 2014 at 11:55 AM, Luis R. Rodriguez wrote: > For the current kernel we > could intake the patch below, and I can port the change to no use > dfs_cac, that would enable older kernels to use new and older versions > of the ASCII database file. Personally I actually rather avoid us accept a patch upstream for a userspace change. The problem here is that we failed to realize the impact of CFG80211_INTERNAL_REGDB at build time with a userspace tool, in this case the db.txt file wireless-regdb provides and its format. If we wanted to avoid a stable patch we could require a match between wireless-regdb input file used for a kernel when CFG80211_INTERNAL_REGDB is used at build time. That would require different ASCII files on wireless-regdb or having the users of CFG80211_INTERNAL_REGDB do the conversion themselves. Upstream would just follow the wireless-regdb latest format. This then would just require upstream a Kconfig update to clarify the requirements. This seems like a rather lazy option but also one that would be rather more fair and honest for upstream, we could deal with a proper fix by reconsidering the implementation of CFG80211_INTERNAL_REGDB completely for future kernels. Luis