Return-path: Received: from mail-ie0-f171.google.com ([209.85.223.171]:42286 "EHLO mail-ie0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755355AbaFKGVl (ORCPT ); Wed, 11 Jun 2014 02:21:41 -0400 Received: by mail-ie0-f171.google.com with SMTP id x19so2961931ier.2 for ; Tue, 10 Jun 2014 23:21:41 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1399798250-20987-1-git-send-email-emmanuel.grumbach@intel.com> <1399798250-20987-3-git-send-email-emmanuel.grumbach@intel.com> Date: Wed, 11 Jun 2014 08:21:41 +0200 Message-ID: (sfid-20140611_082148_303855_A4809AA6) Subject: Re: [PATCH 2/7] cfg80211: introduce regulatory flags controlling bw From: Janusz Dziedzic To: Arik Nemtsov Cc: "Luis R. Rodriguez" , Emmanuel Grumbach , Johannes Berg , linux-wireless , Arik Nemtsov Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: 2014-06-11 7:24 GMT+02:00 Arik Nemtsov : > On Wed, Jun 11, 2014 at 12:28 AM, Luis R. Rodriguez > wrote: >> On Tue, May 20, 2014 at 5:31 AM, Arik Nemtsov wrote: >>> On Tue, May 20, 2014 at 12:54 PM, Luis R. Rodriguez >>> wrote: >>>> On Tue, May 20, 2014 at 2:25 AM, Arik Nemtsov wrote: >>>>> >>>>> Why won't old regdb rules work? The NL80211_RRF_NO_160MHZ for instance >>>>> is not used anywhere in old or new regdbs. >>>>> So all the new code in reg_get_max_bandwidth is ignored in current or >>>>> older crda/regdb flows. >>>>> >>>>> What am I missing? >>>> >>>> It will also be ignored on newer kernels using old wireless-regdb. >>> >>> Is that a problem? >> >> I would have not brought it up otherwise. >> >>> Note that the new flags don't permit more things, but only narrow down >>> the range. So if VHT80 was blocked due to the range, it will still be >>> blocked. >>> Don't really see a reason to use them in newer regdbs either. Like you >>> said - range only is more scalable. >> >> You can keep all those bells and whistles provided you respect old >> userspace and old behavior first. > > I guess I'm waiting for some direction on what need to be changed. > AFAICT, these flags don't hurt old userspace and/or new kernels using > an old wireless-regdb. > Can you propose a scenario where the new flags harm something older? > The flag NL80211_RRF_NO_80MHZ could be usefull I think. eg to fix world regd veryfication issue we have: Current failing line: (2457 - 2482 @ 40), (20), NO-IR --> 2482 - 2457 = 25 < 40 Fixed line could be: (2457 - 2482 @ 40), (20), NO-IR, AUTO-BW, NO-80MHZ Without NO-80MHZ - AUTO-BW will setup BW=80MHz - I am not sure this is OK for 2.4? But setting NO-80MHZ and AUTO-BW flags we will get what expect? BR Janusz