Return-path: Received: from mail-oa0-f50.google.com ([209.85.219.50]:41143 "EHLO mail-oa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750804AbaFVOHx convert rfc822-to-8bit (ORCPT ); Sun, 22 Jun 2014 10:07:53 -0400 Received: by mail-oa0-f50.google.com with SMTP id n16so9253183oag.23 for ; Sun, 22 Jun 2014 07:07:53 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <53A6C8A2.4000202@openwrt.org> References: <1403277721-25302-1-git-send-email-zajec5@gmail.com> <53A6C8A2.4000202@openwrt.org> Date: Sun, 22 Jun 2014 16:07:53 +0200 Message-ID: (sfid-20140622_160945_878802_B777BD16) Subject: Re: [PATCH 1/2] b43: remove leftover code from old devices support From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= To: Felix Fietkau Cc: "linux-wireless@vger.kernel.org" , "John W. Linville" , b43-dev Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 22 June 2014 14:14, Felix Fietkau wrote: > On 2014-06-20 17:22, Rafał Miłecki wrote: >> Old devices (A-PHY or B-PHY) are supposed to be supported by b43legacy. >> We keep phy_a.c as it's needed for G-PHY which shares some design. >> >> Signed-off-by: Rafał Miłecki > Wouldn't it make sense to move the relevant pieces of phy_a.c to phy_g.c > and then remove phy_a.c entirely? > > There are pieces in phy_a.c which can be removed entirely, e.g. > b43_phyops_a and things only used by this struct. Absolutely, however it needs some effort and time. I'm currently quite busy with other things in b43. One could remove b43_phyops_a, then remove newly-unused functions. Then see what code is not used by G-PHY. However you should keep in mind, that 5 GHz support for G-PHY may need some functions that are not called at this moment. So I'd suggest looking at 5 GHz support in G-PHY first to avoid removing sth that may be needed in the future. -- Rafał