Return-path: Received: from mail-lb0-f174.google.com ([209.85.217.174]:59475 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752251AbaFATGO (ORCPT ); Sun, 1 Jun 2014 15:06:14 -0400 Received: by mail-lb0-f174.google.com with SMTP id n15so2025124lbi.5 for ; Sun, 01 Jun 2014 12:06:12 -0700 (PDT) Message-ID: <538B79A3.1080104@cogentembedded.com> (sfid-20140601_210636_367991_2697AE81) Date: Sun, 01 Jun 2014 23:06:11 +0400 From: Sergei Shtylyov MIME-Version: 1.0 To: Michael Braun , Ivo van Doorn , Helmut Schaa CC: netdev@vger.kernel.org, users@rt2x00.serialmonkey.com, linux-wireless@vger.kernel.org, "John W. Linville" , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] rt2800usb:fix efuse detection References: <20140601174736.7980.18330.stgit@charlie.fem.tu-ilmenau.de> <20140601175247.7980.2461.stgit@charlie.fem.tu-ilmenau.de> In-Reply-To: <20140601175247.7980.2461.stgit@charlie.fem.tu-ilmenau.de> Content-Type: text/plain; charset=UTF-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: Hello. On 06/01/2014 09:52 PM, Michael Braun wrote: > The device 057c:8501 (AVM Fritz! WLAN v2 rev. B) currently does not > load. One thing observed is that the vendors driver detects EFUSE mode > for this device, but rt2800usb does not. This is due to rt2800usb > lacking a check for the firmware mode present in the vendors driver, > that this patch adopts for rt2800usb. > With this patch applied, the 'RF chipset' detection does no longer fail. > Signed-off-by: Michael Braun > --- > drivers/net/wireless/rt2x00/rt2800usb.c | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) > diff --git a/drivers/net/wireless/rt2x00/rt2800usb.c b/drivers/net/wireless/rt2x00/rt2800usb.c > index a49c3d7..b601422 100644 > --- a/drivers/net/wireless/rt2x00/rt2800usb.c > +++ b/drivers/net/wireless/rt2x00/rt2800usb.c > @@ -735,11 +735,25 @@ static void rt2800usb_fill_rxdone(struct queue_entry *entry, > /* > * Device probe functions. > */ > +static int rt2800usb_efuse_detect(struct rt2x00_dev *rt2x00dev) > +{ > + __le32 fwMode; > + > + rt2x00usb_vendor_request(rt2x00dev, USB_DEVICE_MODE, > + USB_VENDOR_REQUEST_IN, 0, 0x11, &fwMode, > + sizeof(fwMode), REGISTER_TIMEOUT_FIRMWARE); > + > + if ((fwMode & 0x00000003) == 2) Operating directly on '__le32'? That doesn't look right. > + return 1; > + > + return rt2800_efuse_detect(rt2x00dev); > +} > + WBR, Sergei