Return-path: Received: from mail2.candelatech.com ([208.74.158.173]:52589 "EHLO mail2.candelatech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750708AbaG1UyW (ORCPT ); Mon, 28 Jul 2014 16:54:22 -0400 Message-ID: <53D6B87D.6080007@candelatech.com> (sfid-20140728_225425_375870_9A5C3EAC) Date: Mon, 28 Jul 2014 13:54:21 -0700 From: Ben Greear MIME-Version: 1.0 To: Felix Fietkau CC: linux-wireless@vger.kernel.org, linville@tuxdriver.com, antonio@open-mesh.com Subject: Re: [PATCH] ath9k: fix aggregation session lockup References: <1406122854-60239-1-git-send-email-nbd@openwrt.org> In-Reply-To: <1406122854-60239-1-git-send-email-nbd@openwrt.org> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 07/23/2014 06:40 AM, Felix Fietkau wrote: > If an aggregation session fails, frames still end up in the driver queue > with IEEE80211_TX_CTL_AMPDU set. > This causes tx for the affected station/tid to stall, since > ath_tx_get_tid_subframe returning packets to send. > > Fix this by clearing IEEE80211_TX_CTL_AMPDU as long as no aggregation > session is running. Did this and your previous patch about 'pending tx frames accounting' fix the issues reported? They at least do not fix the problems I see where tx appears to hang, but my setup is pretty 'special'.... Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com