Return-path: Received: from mail-we0-f176.google.com ([74.125.82.176]:49351 "EHLO mail-we0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759323AbaGXPoJ (ORCPT ); Thu, 24 Jul 2014 11:44:09 -0400 Received: by mail-we0-f176.google.com with SMTP id q58so2874387wes.7 for ; Thu, 24 Jul 2014 08:44:06 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1406206914.14675.20.camel@jlt4.sipsolutions.net> References: <1406198362-4999-1-git-send-email-lorenzo.bianconi83@gmail.com> <1406198362-4999-3-git-send-email-lorenzo.bianconi83@gmail.com> <1406200353.14675.18.camel@jlt4.sipsolutions.net> <1406206914.14675.20.camel@jlt4.sipsolutions.net> Date: Thu, 24 Jul 2014 17:44:06 +0200 Message-ID: (sfid-20140724_174413_458134_E16B3249) Subject: Re: [PATCHv2 2/2] mac80211: extend set_coverage_class signature From: Lorenzo Bianconi To: Johannes Berg Cc: linux-wireless , Philippe Duchein Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: > On Thu, 2014-07-24 at 14:12 +0200, Lorenzo Bianconi wrote: >> > On Thu, 2014-07-24 at 12:39 +0200, Lorenzo Bianconi wrote: >> > >> >> @@ -2950,7 +2951,7 @@ struct ieee80211_ops { >> >> int (*get_survey)(struct ieee80211_hw *hw, int idx, >> >> struct survey_info *survey); >> >> void (*rfkill_poll)(struct ieee80211_hw *hw); >> >> - void (*set_coverage_class)(struct ieee80211_hw *hw, u8 coverage_class); >> >> + int (*set_coverage_class)(struct ieee80211_hw *hw, s16 coverage_class); >> > >> > This patch also needs to update all drivers ...... >> >> Currently just ath9k, ath5k and p54 implement set_coverage_class >> function pointer. I would send a different patch for these changes. >> Should I include them in this patchset? > > Guess what will happen if I merge this patch? > > Hint: the kernel will not compile correctly any more. > > johannes > Ok, I will include changes to lower drivers in this patchset. Lorenzo -- UNIX is Sexy: who | grep -i blonde | talk; cd ~; wine; talk; touch; unzip; touch; strip; gasp; finger; gasp; mount; fsck; more; yes; gasp; umount; make clean; sleep