Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:53152 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932727AbaGURai (ORCPT ); Mon, 21 Jul 2014 13:30:38 -0400 From: Kalle Valo To: Janusz Dziedzic CC: , "ath10k@lists.infradead.org" Subject: Re: [PATCH] ath10k: handle attention flags correctly when A-MSDU References: <1405342041-7114-1-git-send-email-janusz.dziedzic@tieto.com> <87pph225mq.fsf@kamboji.qca.qualcomm.com> Date: Mon, 21 Jul 2014 20:30:32 +0300 In-Reply-To: (Janusz Dziedzic's message of "Mon, 21 Jul 2014 10:53:16 +0200") Message-ID: <87ha2ay5zb.fsf@kamboji.qca.qualcomm.com> (sfid-20140721_193047_406251_A9E47EA9) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-wireless-owner@vger.kernel.org List-ID: Janusz Dziedzic writes: > On 18 July 2014 14:50, Kalle Valo wrote: >> Janusz Dziedzic writes: >> >>> In case of A-MSDU RX we should check flags for all >>> MSDU subframes to be sure we have correct FCS status. >>> >>> Before we check attention flags only for first frame >>> where we didn't have correct info about FCS status in >>> case of A-MSDU. Next didn't mark RX_FLAG_FAILED_FCS_CRC >>> for skb. As a side efect we see big TP drop when TCP used. >>> This was easy to reproduce when AP interface was used >>> and added monitor interface run in promiscuous mode. >>> >>> Reported-by: Denton Gentry >>> Signed-off-by: Janusz Dziedzic >> >> I'm having a hard time to understand the commit log. I think it would >> make it easier to read if you first clearly describe the bug you are >> fixing and then, in a separate paragraph, tell how you fix it. > > Will change that. Thanks. What you wrote in this email was really good, I understand the issue now and I'm sure so do others. I think you should put the same in the commit log, there's no max limit for that anyway :) Also add verb "using" to the title: "ath10k: handle attention flags correctly when using A-MSDU" -- Kalle Valo