Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:50548 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755885AbaGRSAM (ORCPT ); Fri, 18 Jul 2014 14:00:12 -0400 Date: Fri, 18 Jul 2014 13:59:15 -0400 From: "John W. Linville" To: Andreas Fenkart Cc: linux-wireless@vger.kernel.org, bzhao@marvell.com, daniel@zonque.org Subject: Re: [PATCH] mwifiex: card reset: enable rescan of non-removable card Message-ID: <20140718175915.GG31114@tuxdriver.com> (sfid-20140718_200018_803080_8093E084) References: <1405670437-18723-1-git-send-email-afenkart@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: <1405670437-18723-1-git-send-email-afenkart@gmail.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Fri, Jul 18, 2014 at 10:00:37AM +0200, Andreas Fenkart wrote: > mmc_rescan will scan for non-removable cards only once, hence the card > will not be rediscovered. > > Signed-off-by: Andreas Fenkart > --- > drivers/net/wireless/mwifiex/sdio.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/wireless/mwifiex/sdio.c b/drivers/net/wireless/mwifiex/sdio.c > index 4ce3d7b..eff3d6e 100644 > --- a/drivers/net/wireless/mwifiex/sdio.c > +++ b/drivers/net/wireless/mwifiex/sdio.c > @@ -1931,6 +1931,7 @@ static void sdio_card_reset_worker(struct work_struct *work) > mmc_remove_host(target); > /* 20ms delay is based on experiment with sdhci controller */ > mdelay(20); > + reset_host->rescan_entered = 0; /* rescan non-removable cards */ > mmc_add_host(target); > } > static DECLARE_WORK(card_reset_work, sdio_card_reset_worker); Building wireless-next: CC drivers/net/wireless/mwifiex/sdio.o drivers/net/wireless/mwifiex/sdio.c: In function ‘mwifiex_sdio_card_reset_work’: drivers/net/wireless/mwifiex/sdio.c:1957:2: error: ‘reset_host’ undeclared (first use in this function) reset_host->rescan_entered = 0; /* rescan non-removable cards */ ^ drivers/net/wireless/mwifiex/sdio.c:1957:2: note: each undeclared identifier is reported only once for each function it appears in -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.