MIME-Version: 1.0
In-Reply-To: <53B93EBC.7010107@broadcom.com>
References: <1404645103-26100-1-git-send-email-zajec5@gmail.com>
	<53B93EBC.7010107@broadcom.com>
Date: Mon, 7 Jul 2014 11:38:01 +0200
Message-ID: <CACna6rwt3vr0cHxRR8XkSg+C9NDN5Oxi8Syus8fGBpGLJVVYPw@mail.gmail.com> (sfid-20140707_113807_249849_5837EF70)
Subject: Re: [PATCH] bcma: support for PCIe Gen 2 as host platform
From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>
To: Arend van Spriel <arend@broadcom.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"John W. Linville" <linville@tuxdriver.com>,
	b43-dev <b43-dev@lists.infradead.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-wireless-owner@vger.kernel.org

On 6 July 2014 14:19, Arend van Spriel <arend@broadcom.com> wrote:
> On 06-07-14 13:11, Rafał Miłecki wrote:
>> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
>> ---
>> I got reply from Bjorn, that we should *not* depend on PCI_EXP_LNKCAP:
>> http://marc.info/?l=linux-pci&m=140457671930896&w=2
>>
>> So the change since RFC is adding a list of PCIe 1.0 and 2.0 devices.
>> Use PCI_EXP_LNKCAP only as a fallback, in case someone tries sth like:
>> echo "14e4 4360" > /sys/bus/pci/drivers/bcma-pci-bridge/new_id
>
> Do you have to know this before or after enumerating the cores? They
> have a different core id, right?

Sure, having a list of cores would allow me to determine PCIe revision.

Unfortunately right now we have only this single bcma_bus_register
call that does both: scanning and initialization. I'd need to first
scan cores, then determine PCIe revision and finally initialize cores.

I wonder if I could try to use bcma_bus_scan_early that was developer
for SoC needs...