Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:48582 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751095AbaGGSaL (ORCPT ); Mon, 7 Jul 2014 14:30:11 -0400 Date: Mon, 7 Jul 2014 14:23:02 -0400 From: "John W. Linville" To: Hans de Goede Cc: Arend van Spriel , Chen-Yu Tsai , linux-wireless@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree , linux-sunxi@googlegroups.com Subject: Re: [PATCH v3 1/4] dt: bindings: add bindings for Broadcom bcm43xx sdio devices Message-ID: <20140707182302.GA29650@tuxdriver.com> (sfid-20140707_203019_019718_7267F678) References: <1404051421-24377-1-git-send-email-hdegoede@redhat.com> <1404051421-24377-2-git-send-email-hdegoede@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1404051421-24377-2-git-send-email-hdegoede@redhat.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: Any word from the devicetree folks? On Sun, Jun 29, 2014 at 04:16:58PM +0200, Hans de Goede wrote: > From: Arend van Spriel > > The Broadcom bcm43xx sdio devices are fullmac devices that may be > integrated in ARM platforms. Currently, the brcmfmac driver for > these devices support use of platform data. This patch specifies > the bindings that allow this platform data to be expressed in the > devicetree. > > Reviewed-by: Hante Meuleman > Reviewed-by: Franky (Zhenhui) Lin > Reviewed-by: Daniel (Deognyoun) Kim > Reviewed-by: Pieter-Paul Giesberts > Signed-off-by: Arend van Spriel > [hdegoede@redhat.com: drop clk / reg_on gpio handling, as there is no consensus > on how to handle this yet] > [hdegoede@redhat.com: move from bindings/staging to bindings] > Signed-off-by: Hans de Goede > --- > .../bindings/net/wireless/brcm,bcm43xx-fmac.txt | 41 ++++++++++++++++++++++ > 1 file changed, 41 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt > > diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt b/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt > new file mode 100644 > index 0000000..5dbf169 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt > @@ -0,0 +1,41 @@ > +Broadcom BCM43xx Fullmac wireless SDIO devices > + > +This node provides properties for controlling the Broadcom wireless device. The > +node is expected to be specified as a child node to the SDIO controller that > +connects the device to the system. > + > +Required properties: > + > + - compatible : Should be "brcm,bcm4329-fmac". > + > +Optional properties: > + - brcm,drive-strength : drive strength used for SDIO pins on device in mA > + (default = 6). > + - interrupt-parent : the phandle for the interrupt controller to which the > + device interrupts are connected. > + - interrupts : specifies attributes for the out-of-band interrupt (host-wake). > + When not specified the device will use in-band SDIO interrupts. > + - interrupt-names : name of the out-of-band interrupt, which must be set > + to "host-wake". > + > +Example: > + > +mmc3: mmc@01c12000 { > + #address-cells = <1>; > + #size-cells = <0>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&mmc3_pins_a>; > + vmmc-supply = <®_vmmc3>; > + bus-width = <4>; > + non-removable; > + status = "okay"; > + > + brcmf: bcrmf@1 { > + reg = <1>; > + compatible = "brcm,bcm4329-fmac"; > + interrupt-parent = <&pio>; > + interrupts = <10 8>; /* PH10 / EINT10 */ > + interrupt-names = "host-wake"; > + }; > +}; > -- > 2.0.0 > > -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.