Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:50599 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751264AbaGGVAP (ORCPT ); Mon, 7 Jul 2014 17:00:15 -0400 Date: Mon, 7 Jul 2014 16:48:46 -0400 From: "John W. Linville" To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Arend van Spriel , "linux-wireless@vger.kernel.org" , b43-dev Subject: Re: [PATCH] bcma: support for PCIe Gen 2 as host platform Message-ID: <20140707204846.GF29650@tuxdriver.com> (sfid-20140707_230021_823504_0FD72EB3) References: <1404645103-26100-1-git-send-email-zajec5@gmail.com> <53B93EBC.7010107@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, Jul 07, 2014 at 09:37:10PM +0200, Rafał Miłecki wrote: > On 7 July 2014 11:38, Rafał Miłecki wrote: > > On 6 July 2014 14:19, Arend van Spriel wrote: > >> On 06-07-14 13:11, Rafał Miłecki wrote: > >>> Signed-off-by: Rafał Miłecki > >>> --- > >>> I got reply from Bjorn, that we should *not* depend on PCI_EXP_LNKCAP: > >>> http://marc.info/?l=linux-pci&m=140457671930896&w=2 > >>> > >>> So the change since RFC is adding a list of PCIe 1.0 and 2.0 devices. > >>> Use PCI_EXP_LNKCAP only as a fallback, in case someone tries sth like: > >>> echo "14e4 4360" > /sys/bus/pci/drivers/bcma-pci-bridge/new_id > >> > >> Do you have to know this before or after enumerating the cores? They > >> have a different core id, right? > > > > Sure, having a list of cores would allow me to determine PCIe revision. > > > > Unfortunately right now we have only this single bcma_bus_register > > call that does both: scanning and initialization. I'd need to first > > scan cores, then determine PCIe revision and finally initialize cores. > > > > I wonder if I could try to use bcma_bus_scan_early that was developer > > for SoC needs... > > John: please kindly drop this patch for now. All other bcma/b43 > patches are unaffected. OK -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.