Return-path: Received: from mail-oa0-f53.google.com ([209.85.219.53]:47603 "EHLO mail-oa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750999AbaGGThL convert rfc822-to-8bit (ORCPT ); Mon, 7 Jul 2014 15:37:11 -0400 Received: by mail-oa0-f53.google.com with SMTP id l6so5213009oag.40 for ; Mon, 07 Jul 2014 12:37:10 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1404645103-26100-1-git-send-email-zajec5@gmail.com> <53B93EBC.7010107@broadcom.com> Date: Mon, 7 Jul 2014 21:37:10 +0200 Message-ID: (sfid-20140707_213722_384556_6ED28003) Subject: Re: [PATCH] bcma: support for PCIe Gen 2 as host platform From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= To: Arend van Spriel Cc: "linux-wireless@vger.kernel.org" , "John W. Linville" , b43-dev Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 7 July 2014 11:38, Rafał Miłecki wrote: > On 6 July 2014 14:19, Arend van Spriel wrote: >> On 06-07-14 13:11, Rafał Miłecki wrote: >>> Signed-off-by: Rafał Miłecki >>> --- >>> I got reply from Bjorn, that we should *not* depend on PCI_EXP_LNKCAP: >>> http://marc.info/?l=linux-pci&m=140457671930896&w=2 >>> >>> So the change since RFC is adding a list of PCIe 1.0 and 2.0 devices. >>> Use PCI_EXP_LNKCAP only as a fallback, in case someone tries sth like: >>> echo "14e4 4360" > /sys/bus/pci/drivers/bcma-pci-bridge/new_id >> >> Do you have to know this before or after enumerating the cores? They >> have a different core id, right? > > Sure, having a list of cores would allow me to determine PCIe revision. > > Unfortunately right now we have only this single bcma_bus_register > call that does both: scanning and initialization. I'd need to first > scan cores, then determine PCIe revision and finally initialize cores. > > I wonder if I could try to use bcma_bus_scan_early that was developer > for SoC needs... John: please kindly drop this patch for now. All other bcma/b43 patches are unaffected. -- Rafał