Return-path: Received: from tundra.namei.org ([65.99.196.166]:34019 "EHLO namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751237AbaGTXqO (ORCPT ); Sun, 20 Jul 2014 19:46:14 -0400 Date: Mon, 21 Jul 2014 09:43:57 +1000 (EST) From: James Morris To: Kees Cook cc: LKML , Ming Lei , "Luis R. Rodriguez" , Greg Kroah-Hartman , James Morris , David Howells , "linux-doc@vger.kernel.org" , linux-security-module , linux-firmware@kernel.org, linux-wireless Subject: Re: [PATCH 4/7] firmware_class: perform new LSM checks In-Reply-To: Message-ID: (sfid-20140721_014629_252433_A2924C80) References: <1405373897-31671-1-git-send-email-keescook@chromium.org> <1405373897-31671-5-git-send-email-keescook@chromium.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-wireless-owner@vger.kernel.org List-ID: On Sat, 19 Jul 2014, Kees Cook wrote: [...] > With the patch series, the LSM hook sees the userspace-touching loads: > - from kernel built-in: no LSM hook (nonsense to check the static list) > - direct from filesystem: called with file struct > - via uevent /sys "loading"/"data" interface: called with NULL file struct > - via uevent /sys "fd" interface: called with file struct Thanks for the overview. Can we get this documented in the LSM code? > The reason the "fd" interface was added was because otherwise there's > no way for systems that use the uevent handler to communicate to the > kernel where the bytes being shoved into the "data" interface are > coming from. Ok. I gather folks have also thought about signing firmware? -- James Morris