Return-path: Received: from mail.linuxfoundation.org ([140.211.169.12]:33052 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750941AbaH1VGz (ORCPT ); Thu, 28 Aug 2014 17:06:55 -0400 Date: Thu, 28 Aug 2014 14:06:54 -0700 From: Andrew Morton To: Andy Shevchenko Cc: "John W. Linville" , Andy Shevchenko , Johannes Berg , devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org, "linux-kernel@vger.kernel.org" , Greg Kroah-Hartman , Joe Perches Subject: Re: [PATCH v3 00/11] lib: introduce string_escape_mem and %*pE specifier Message-Id: <20140828140654.d5599d2252386df98a57db64@linux-foundation.org> (sfid-20140828_230720_789153_BCFCF271) In-Reply-To: References: <1408527772-27224-1-git-send-email-andriy.shevchenko@linux.intel.com> <20140828183330.GM13758@tuxdriver.com> <20140828120851.07dbd1c52ec287ca169acee4@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, 28 Aug 2014 23:58:45 +0300 Andy Shevchenko wrote: > On Thu, Aug 28, 2014 at 10:08 PM, Andrew Morton > wrote: > > On Thu, 28 Aug 2014 14:33:30 -0400 "John W. Linville" wrote: > > > >> On Wed, Aug 20, 2014 at 12:42:41PM +0300, Andy Shevchenko wrote: > >> > The introduced function is a kind of opposite to string_unescape. We have > >> > several users of such functionality each of them created custom implementation. > >> > The series contains clean up of test suite, adding new call, and switching few > >> > users to use it via %*pE specifier. > >> > >> Any objections? Do you (Andy) want me to merge this through the > >> wireless tree? > >> > > > > Who is this top-poster and what have you done with John? > > > > I was going to apply them yesterday but in [4/11] Andy said he plans on > > sending out a v5. (v4 actually?) > > For now (so far no more comments) it is only couple of trivia fixes > (removing useless comments). Would you like to resend whole series or > just fixup would be enough? I fixed up the one Joe commented on. --- a/lib/vsprintf.c~lib-vsprintf-add-%pe-format-specifier-fix +++ a/lib/vsprintf.c @@ -1111,12 +1111,11 @@ char *escaped_string(char *buf, char *en int len; if (spec.field_width == 0) - /* nothing to print */ - return buf; + return buf; /* nothing to print */ if (ZERO_OR_NULL_PTR(addr)) - /* NULL pointer */ - return string(buf, end, NULL, spec); + return string(buf, end, NULL, spec); /* NULL pointer */ + do { switch (fmt[count++]) { _