Return-path: Received: from mail-lb0-f172.google.com ([209.85.217.172]:36078 "EHLO mail-lb0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753030AbaH2TXu (ORCPT ); Fri, 29 Aug 2014 15:23:50 -0400 MIME-Version: 1.0 In-Reply-To: <5400C3E8.9040500@broadcom.com> References: <1409329464-768-1-git-send-email-geert@linux-m68k.org> <5400C3E8.9040500@broadcom.com> Date: Fri, 29 Aug 2014 21:23:48 +0200 Message-ID: (sfid-20140829_212411_223188_E0241148) Subject: Re: [PATCH] brcmfmac: BRCMFMAC should depend on HAS_DMA From: Geert Uytterhoeven To: Franky Lin Cc: Brett Rudley , "John W. Linville" , "David S. Miller" , linux-wireless , brcm80211-dev-list@broadcom.com, "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi Franky, On Fri, Aug 29, 2014 at 8:18 PM, Franky Lin wrote: >> config BRCMFMAC >> tristate "Broadcom IEEE802.11n embedded FullMAC WLAN driver" >> - depends on CFG80211 >> + depends on CFG80211A && HAS_DMA >> select BRCMUTIL >> ---help--- >> This module adds support for embedded wireless adapters based on > > Thanks for reporting this. All complaints are from msgbuf code. So the > dependency should belong to BRCMFMAC_PCIE not BRCMFMAC. I have PCI=n, hence BRCMFMAC_PCIE=n. IIRC, I did try adding the HAS_DMA dependencies to the suboptions, but then it still failed to link. Hence I restored to the main BRCMFMAC. Besides, msgbuf.o is part of the core. I've just tried moving it to brcmfmac-$(CONFIG_BRCMFMAC_PCIE), but that doesn't help. Other parts use msgbuf, too. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds