Return-path: Received: from s3.sipsolutions.net ([5.9.151.49]:38703 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754581AbaHZICs (ORCPT ); Tue, 26 Aug 2014 04:02:48 -0400 Message-ID: <1409040095.2489.3.camel@jlt4.sipsolutions.net> (sfid-20140826_100405_348519_47B836DC) Subject: Re: [PATCH][input-led] Defer input led work to workqueue From: Johannes Berg To: Samuel Thibault Cc: Hugh Dickins , akpm@linux-foundation.org, Sabrina Dubroca , Valdis.Kletnieks@vt.edu, Vincent Donnefort , Bryan Wu , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org Date: Tue, 26 Aug 2014 10:01:35 +0200 In-Reply-To: <20140826015453.GA5235@type.youpi.perso.aquilenet.fr> (sfid-20140826_040254_816162_A52F1B31) References: <20140826015453.GA5235@type.youpi.perso.aquilenet.fr> (sfid-20140826_040254_816162_A52F1B31) Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, 2014-08-26 at 03:54 +0200, Samuel Thibault wrote: > + vt_led_wq = alloc_workqueue("input_leds", WQ_UNBOUND, 0); > + if (!vt_led_wq) > + return -ENOMEM; Does this really need a separate workqueue rather than just using schedule_work()? There doesn't seem to be much point in having its own workqueue really, to me. johannes