Return-path: Received: from mail-pd0-f179.google.com ([209.85.192.179]:47343 "EHLO mail-pd0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755080AbaHYWCa (ORCPT ); Mon, 25 Aug 2014 18:02:30 -0400 Received: by mail-pd0-f179.google.com with SMTP id v10so21180119pde.38 for ; Mon, 25 Aug 2014 15:02:30 -0700 (PDT) Date: Mon, 25 Aug 2014 15:00:44 -0700 (PDT) From: Hugh Dickins To: Samuel Thibault , Sabrina Dubroca , Valdis.Kletnieks@vt.edu, Hugh Dickins , Vincent Donnefort , Bryan Wu , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org Subject: Re: 3.17-rc1: leds blink workqueue causes sleeping BUGs In-Reply-To: <20140825213752.GD3070@type.youpi.perso.aquilenet.fr> Message-ID: (sfid-20140826_000253_962933_F7E698BA) References: <10857.1408467967@turing-police.cc.vt.edu> <20140825211340.GA22168@kria> <20140825212324.GC3070@type.youpi.perso.aquilenet.fr> <20140825213752.GD3070@type.youpi.perso.aquilenet.fr> MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="0-1686296495-1409004052=:26438" Sender: linux-wireless-owner@vger.kernel.org List-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --0-1686296495-1409004052=:26438 Content-Type: TEXT/PLAIN; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE On Mon, 25 Aug 2014, Samuel Thibault wrote: > Samuel Thibault, le Mon 25 Aug 2014 23:23:24 +0200, a =E9crit : > > We could indeed have a loop if the user was making the VT::* leds use > > the vt-* trigger, >=20 > Actually, while there can be a loop, it wouldn't be possible to inject > events in it: a VT::* led only makes the corresponding vt-* trigger if > it got an event from its trigger, etc. So it's really a false positive, > the lock detector just can not know that it can not happen. I'm not suffering from this lockdep warning myself; but, false positive or not, it does need to be fixed (or annotated). Because once lockdep reports one issue, it turns itself off. So any developer who hits this warning is then unable test their own changes with lockdep afterwards. Hugh --0-1686296495-1409004052=:26438--