Date: Tue, 26 Aug 2014 15:32:38 +0200
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Johannes Berg <johannes@sipsolutions.net>,
	Hugh Dickins <hughd@google.com>, akpm@linux-foundation.org,
	Sabrina Dubroca <sd@queasysnail.net>, Valdis.Kletnieks@vt.edu,
	Vincent Donnefort <vdonnefort@gmail.com>,
	Bryan Wu <cooloney@gmail.com>, linux-leds@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCHv2][input-led] Defer input led work to workqueue
Message-ID: <20140826133238.GA28108@type.bordeaux.inria.fr> (sfid-20140826_153245_073204_51EC8797)
References: <20140826015453.GA5235@type.youpi.perso.aquilenet.fr>
 <20140826091725.GA23293@type.youpi.perso.aquilenet.fr>
 <1409059327.22232.0.camel@jlt4.sipsolutions.net>
 <20140826132410.GD3186@type.bordeaux.inria.fr>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
In-Reply-To: <20140826132410.GD3186@type.bordeaux.inria.fr>
Sender: linux-wireless-owner@vger.kernel.org

Samuel Thibault, le Tue 26 Aug 2014 15:24:10 +0200, a ?crit :
> Johannes Berg, le Tue 26 Aug 2014 15:22:07 +0200, a ?crit :
> > On Tue, 2014-08-26 at 11:17 +0200, Samuel Thibault wrote:
> > 
> > > -	led_trigger_event(&vt_led_triggers[led], !!brightness);
> > > +	vt_led_state[led] = !!brightness;
> > > +	schedule_work(&vt_led_work[led]);
> > 
> > 
> > > +static int __init input_led_init(void)
> > > +{
> > > +	unsigned i;
> > > +
> > > +	for (i = 0; i < LED_CNT; i++)
> > > +		INIT_WORK(&vt_led_work[i], vt_led_cb);
> > > +
> > > +	return 0;
> > > +}
> > > +
> > > +static void __exit input_led_exit(void)
> > > +{
> > > +}
> > 
> > Come to think of it - don't you need to cancel_work_sync() in exit so
> > the work struct can't be queued while the module is being unloaded?
> 
> Well, this is never built as a module ATM, so it's not a problem.

(but I have changed that for future versions of the whole patch, yes)

Samuel