Return-path: Received: from mga01.intel.com ([192.55.52.88]:61458 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751078AbaIAHQ1 (ORCPT ); Mon, 1 Sep 2014 03:16:27 -0400 Message-ID: <1409555763.30155.39.camel@linux.intel.com> (sfid-20140901_091653_875448_F235DA26) Subject: Re: [PATCH v3 07/11] wireless: hostap: proc: print properly escaped SSID From: Andy Shevchenko To: "John W . Linville" Cc: Johannes Berg , devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Andrew Morton , Joe Perches Date: Mon, 01 Sep 2014 10:16:03 +0300 In-Reply-To: <1408527772-27224-8-git-send-email-andriy.shevchenko@linux.intel.com> References: <1408527772-27224-1-git-send-email-andriy.shevchenko@linux.intel.com> <1408527772-27224-8-git-send-email-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, 2014-08-20 at 12:42 +0300, Andy Shevchenko wrote: > Instead of substituting non-printable characters by '_' let's print SSID > properly escaped by using recently added %*pE specifier. Here is kbuild robot fixup. >From f88ff364a1b117d3c86186206eeaa54ff906147a Mon Sep 17 00:00:00 2001 From: Andy Shevchenko Date: Mon, 1 Sep 2014 10:13:28 +0300 Subject: [PATCH] wireless: hostap: kbuild robot fixup Signed-off-by: Andy Shevchenko --- drivers/net/wireless/hostap/hostap_proc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/hostap/hostap_proc.c b/drivers/net/wireless/hostap/hostap_proc.c index 16a06b6..5b1a510 100644 --- a/drivers/net/wireless/hostap/hostap_proc.c +++ b/drivers/net/wireless/hostap/hostap_proc.c @@ -181,7 +181,7 @@ static int prism2_bss_list_proc_show(struct seq_file *m, void *v) bss->bssid, bss->last_update, bss->count, bss->capab_info); - seq_printf(m, "%*pE", bss->ssid_len, bss->ssid); + seq_printf(m, "%*pE", (int)bss->ssid_len, bss->ssid); seq_putc(m, '\t'); for (i = 0; i < bss->ssid_len; i++) -- 2.1.0 > > Signed-off-by: Andy Shevchenko > --- > drivers/net/wireless/hostap/hostap_proc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/net/wireless/hostap/hostap_proc.c b/drivers/net/wireless/hostap/hostap_proc.c > index 4e5c0f8..16a06b6 100644 > --- a/drivers/net/wireless/hostap/hostap_proc.c > +++ b/drivers/net/wireless/hostap/hostap_proc.c > @@ -181,9 +181,7 @@ static int prism2_bss_list_proc_show(struct seq_file *m, void *v) > bss->bssid, bss->last_update, > bss->count, bss->capab_info); > > - for (i = 0; i < bss->ssid_len; i++) > - seq_putc(m,bss->ssid[i] >= 32 && bss->ssid[i] < 127 ? > - bss->ssid[i] : '_'); > + seq_printf(m, "%*pE", bss->ssid_len, bss->ssid); > > seq_putc(m, '\t'); > for (i = 0; i < bss->ssid_len; i++) -- Andy Shevchenko Intel Finland Oy