Return-path: Received: from mail2.candelatech.com ([208.74.158.173]:49555 "EHLO mail2.candelatech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752584AbaI2P67 (ORCPT ); Mon, 29 Sep 2014 11:58:59 -0400 Message-ID: <542981C1.7020000@candelatech.com> (sfid-20140929_175902_974347_8AAEFED0) Date: Mon, 29 Sep 2014 08:58:57 -0700 From: Ben Greear MIME-Version: 1.0 To: Kalle Valo CC: Michal Kazior , linux-wireless , "ath10k@lists.infradead.org" Subject: Re: [PATCH] ath10k: request firmware flush in ath10k_flush. References: <1411151304-31544-1-git-send-email-greearb@candelatech.com> <5421818A.9040501@candelatech.com> <871tqu3dgu.fsf@kamboji.qca.qualcomm.com> In-Reply-To: <871tqu3dgu.fsf@kamboji.qca.qualcomm.com> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 09/29/2014 03:53 AM, Kalle Valo wrote: >> Thanks. I think ath10k should do this instead of having CT-specific >> flush eventually. > > I agree. We should not be forking functionality unless absolutely > necessary. Ok, this patch is easy to carry in my own tree. But, for things upstream firmware just cannot support, like tx-rate-status and rx-software-crypt, how do you want it flagged in the driver? Can I get the CT firmware flag in for that, or does it have to be some other way? If you just will not accept any such patch, let me know so I can quite bothering you about it. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com