Return-path: Received: from mail-lb0-f173.google.com ([209.85.217.173]:34208 "EHLO mail-lb0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751073AbaIVHm6 (ORCPT ); Mon, 22 Sep 2014 03:42:58 -0400 Message-ID: <541FD2FE.3090102@gmail.com> (sfid-20140922_094320_988938_6298514C) Date: Mon, 22 Sep 2014 10:42:54 +0300 From: Kari Suvanto MIME-Version: 1.0 To: Samuel Thibault CC: Hugh Dickins , Sabrina Dubroca , Valdis.Kletnieks@vt.edu, Bryan Wu , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org Subject: Re: 3.17-rc1: leds blink workqueue causes sleeping BUGs Content-Type: text/plain; charset=utf-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: >Ew. I'll have a look. sorry, sending again, first one had html in it.. Any update on this one? I'm seeing this in every boot. I patched this by changing led_trigger_register and led_trigger_register_simple as macros which creates a static lock_class_key like this: -extern int led_trigger_register(struct led_trigger *trigger); + +extern int __led_trigger_register_key(struct led_trigger *trigger, + struct lock_class_key *key); +#ifdef CONFIG_LOCKDEP +#define led_trigger_register(trigger) \ +({ \ + static struct lock_class_key __key; \ + \ + __led_trigger_register_key(trigger, &__key); \ +}) +#else +#define led_trigger_register(trigger) \ + __led_trigger_register_key(trigger, NULL) +#endif + But should every trigger has own key? With my patch all the triggers from vt/keyboard.c are using the same key. Is that a problem? I have not seen any problems with that patch and after that I can see this https://lkml.org/lkml/2014/9/5/462. -Kari