Return-path: Received: from s3.sipsolutions.net ([5.9.151.49]:44381 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756061AbaIEJ4d (ORCPT ); Fri, 5 Sep 2014 05:56:33 -0400 Message-ID: <1409910985.1940.6.camel@jlt4.sipsolutions.net> (sfid-20140905_115658_853247_F4F935B6) Subject: Re: [RFC v2] device coredump: add new device coredump class From: Johannes Berg To: Jonas Gorski Cc: "linux-kernel@vger.kernel.org" , Greg Kroah-Hartman , Daniel Vetter , Emmanuel Grumbach , Luciano Coelho , Kalle Valo , dri-devel@lists.freedesktop.org, "linux-wireless@vger.kernel.org" Date: Fri, 05 Sep 2014 11:56:25 +0200 In-Reply-To: References: <1409907054-17596-1-git-send-email-johannes@sipsolutions.net> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Fri, 2014-09-05 at 11:40 +0200, Jonas Gorski wrote: > On Fri, Sep 5, 2014 at 10:50 AM, Johannes Berg > wrote: > > From: Johannes Berg > > Can't you just send from the correct address? ;p Not easily :) > How about the following to avoid negative options: > > config DEV_COREDUMP > bool "Enable device coredump" if EXPERT > default y if WANT_DEV_COREDUMP > help > Enable the device coredump mechanism for drivers wanting to > use it. Disabling allows for more sensitive systems or systems that > don't want to ever access the information to not have the code, > nor keep any data. > > If unsure, say Y. Yeah, that seems reasonable. I guess I did the negative option because I was thinking about the negative case ("I really don't want this!!! 111!!") :) johannes