Return-path: Received: from mail-ig0-f181.google.com ([209.85.213.181]:43645 "EHLO mail-ig0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752311AbaIAJYl (ORCPT ); Mon, 1 Sep 2014 05:24:41 -0400 MIME-Version: 1.0 In-Reply-To: <53FCFCF0.2010704@hauke-m.de> References: <1408915485-8078-1-git-send-email-hauke@hauke-m.de> <1408915485-8078-5-git-send-email-hauke@hauke-m.de> <8344390.rjnOcYBCET@wuerfel> <53FCFCF0.2010704@hauke-m.de> Date: Mon, 1 Sep 2014 11:24:40 +0200 Message-ID: (sfid-20140901_112445_048213_B96AC8AB) Subject: Re: [RFC 3/7] bcm47xx-sprom: add Broadcom sprom parser driver From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= To: Hauke Mehrtens , Arnd Bergmann , Greg Kroah-Hartman Cc: "linux-arm-kernel@lists.infradead.org" , "linux-wireless@vger.kernel.org" , devicetree@vger.kernel.org, "linux-mips@linux-mips.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 26 August 2014 23:32, Hauke Mehrtens wrote: > On 08/25/2014 09:52 AM, Arnd Bergmann wrote: >> On Sunday 24 August 2014 23:24:41 Hauke Mehrtens wrote: >>> drivers/misc/Kconfig | 14 + >>> drivers/misc/Makefile | 1 + >>> drivers/misc/bcm47xx-sprom.c | 690 +++++++++++++++++++++ >> >> On a similar note, putting the driver into drivers/misc seems >> suboptimal: misc drivers should by definition be something that >> is for some odd hardware with no external dependencies on it, >> whereas your driver seems to be used by multiple other drivers. >> >> Would it make sense to put it into drivers/bcma when that is the >> only bus it is used on? > > As Jonas already said this code should be used for the bcm53xx ARM code > and the bcm47xx MIPS code and it is needed for drivers/bcma/ and > drivers/ssb/ (ssb only for old mips devices). Do you have any better > idea than putting this to drivers/misc/ ? For the mips SoC we need the > code very early and will not use the driver interface but probably > directly call the function name. Ping? Does anyone have any better idea? Both: nvram and sprom drivers will be used by bcm47xx (mips) and bcm53xx (arm). They can't be put in drivers/bcma, as they are used by drivers/ssb as well.