Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:17246 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751412AbaIWM7M (ORCPT ); Tue, 23 Sep 2014 08:59:12 -0400 From: Kalle Valo To: CC: , Subject: Re: [PATCH 3/3] ath10k: support 32+ stations. References: <1411149890-12618-1-git-send-email-greearb@candelatech.com> <1411149890-12618-3-git-send-email-greearb@candelatech.com> Date: Tue, 23 Sep 2014 15:59:06 +0300 In-Reply-To: <1411149890-12618-3-git-send-email-greearb@candelatech.com> (greearb@candelatech.com's message of "Fri, 19 Sep 2014 11:04:50 -0700") Message-ID: <874mvyebmt.fsf@kamboji.qca.qualcomm.com> (sfid-20140923_145915_360233_F78C5A0D) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-wireless-owner@vger.kernel.org List-ID: greearb@candelatech.com writes: > From: Ben Greear > > Support up to 32 stations when using CT firmware. > > Signed-off-by: Ben Greear [...] > - if (test_bit(ATH10K_FW_FEATURE_WMI_10X, ar->fw_features)) > + if (test_bit(ATH10K_FW_FEATURE_WMI_10X_CT, ar->fw_features)) > + ar->free_vdev_map = (1LL << TARGET_10X_NUM_VDEVS_CT) - 1; > + else if (test_bit(ATH10K_FW_FEATURE_WMI_10X, ar->fw_features)) > ar->free_vdev_map = (1LL << TARGET_10X_NUM_VDEVS) - 1; > else > ar->free_vdev_map = (1LL << TARGET_NUM_VDEVS) - 1; [...] > +/* Over-rides for Candela Technologies firmware */ > +#define TARGET_10X_NUM_VDEVS_CT 32 > +#define TARGET_10X_NUM_PEERS_CT (32 + (TARGET_10X_NUM_VDEVS_CT)) > +#define TARGET_10X_AST_SKID_LIMIT_CT (TARGET_10X_NUM_PEERS_CT * TARGET_10X_NUM_PEER_AST) [...] > + if (test_bit(ATH10K_FW_FEATURE_WMI_10X_CT, ar->fw_features)) > + max_num_peers = TARGET_10X_NUM_PEERS_CT - 1; Like I said before, this hardcoding of values using feature bits is not going to work in the long run. It's better that these values come directly from FW IEs as integers, that gives us a lot more flexibility between firmware versions. That's why I'll drop patches 2 and 3. -- Kalle Valo