Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:39766 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932401AbaIWPAP (ORCPT ); Tue, 23 Sep 2014 11:00:15 -0400 Date: Tue, 23 Sep 2014 10:46:27 -0400 From: "John W. Linville" To: Kalle Valo Cc: Joe Perches , Vladimir Kondratiev , ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, wil6210 , ath6kl@lists.infradead.org Subject: Re: [PATCH] ath: change logging functions to return void Message-ID: <20140923144627.GG23806@tuxdriver.com> (sfid-20140923_170141_518181_C2CF1310) References: <1411407334.2952.46.camel@joe-AO725> <874mvzj7bu.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <874mvzj7bu.fsf@kamboji.qca.qualcomm.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, Sep 23, 2014 at 07:20:53AM +0300, Kalle Valo wrote: > Joe Perches writes: > > > The return values are not used by callers of these functions > > so change the functions to return void. > > > > Other miscellanea: > > > > o add __printf verification to wil6210 logging functions > > No format/argument mismatches found > > > > Signed-off-by: Joe Perches > > --- > > This change is associated to a desire to eventually > > change printk to return void. > > > > drivers/net/wireless/ath/ath10k/debug.c | 18 +++++------------- > > drivers/net/wireless/ath/ath10k/debug.h | 6 +++--- > > drivers/net/wireless/ath/ath6kl/common.h | 2 +- > > drivers/net/wireless/ath/ath6kl/debug.c | 28 ++++++++-------------------- > > drivers/net/wireless/ath/ath6kl/debug.h | 13 ++++++------- > > For ath6kl and ath10k: > > Acked-by: Kalle Valo > > > drivers/net/wireless/ath/wil6210/debug.c | 14 ++++---------- > > drivers/net/wireless/ath/wil6210/wil6210.h | 7 +++++-- > > 7 files changed, 32 insertions(+), 56 deletions(-) > > John, as this patch also contains a wil6210 change how do you want to > handle this? I had presumed that you would merge it through the ath tree, so I deleted it... John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.