Return-path: Received: from sabertooth02.qualcomm.com ([65.197.215.38]:54898 "EHLO sabertooth02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932545AbaJWNOI (ORCPT ); Thu, 23 Oct 2014 09:14:08 -0400 From: Kalle Valo To: Michal Kazior CC: "ath10k@lists.infradead.org" , linux-wireless Subject: Re: [PATCH v2 4/6] ath10k: make warm reset a bit safer and faster References: <1413807282-27951-1-git-send-email-michal.kazior@tieto.com> <1413807282-27951-5-git-send-email-michal.kazior@tieto.com> Date: Thu, 23 Oct 2014 16:14:00 +0300 In-Reply-To: (Michal Kazior's message of "Thu, 23 Oct 2014 10:27:57 +0200") Message-ID: <871tpzq67b.fsf@kamboji.qca.qualcomm.com> (sfid-20141023_151413_631442_DC19A83E) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-wireless-owner@vger.kernel.org List-ID: Michal Kazior writes: > On 20 October 2014 14:14, Michal Kazior wrote: >> One of the problems with warm reset I've found is >> that it must be guaranteed that copy engine >> registers are not being accessed while being >> reset. Otherwise in worst case scenario the host >> may lock up. >> >> Instead of using sleeps and hoping the device is >> operational in some arbitrary timeframes use >> firmware indication register. >> >> As a side effect this makes driver >> boot/stop/recovery faster. >> >> Signed-off-by: Michal Kazior >> --- >> >> Notes: >> v2: >> * fix kernel panic on early fw crash due to CE not being fully initialized [Janusz] > > Marek reported he sees a memory leak and git bisect blames this patch. > Please don't apply this patch yet. Ok, thanks for letting me know. What about rest of the patches in the patchset? I assume it's safe to apply them. -- Kalle Valo