Return-path: Received: from mail-pd0-f169.google.com ([209.85.192.169]:56465 "EHLO mail-pd0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750815AbaJIRP3 (ORCPT ); Thu, 9 Oct 2014 13:15:29 -0400 Date: Thu, 9 Oct 2014 10:15:24 -0700 From: Guenter Roeck To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: "linux-wireless@vger.kernel.org" , Linux Kernel Mailing List , Hauke Mehrtens , Arnd Bergmann Subject: Re: [PATCH] bcma: Add dependency on OF_ADDRESS Message-ID: <20141009171523.GA2410@roeck-us.net> (sfid-20141009_191604_919847_267D5E0F) References: <1412872877-1771-1-git-send-email-linux@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, Oct 09, 2014 at 06:54:48PM +0200, Rafał Miłecki wrote: > On 9 October 2014 18:41, Guenter Roeck wrote: > > Commit 2101e533f41a ("bcma: register bcma as device tree driver") > > introduces a hard dependency on OF_ADDRESS into the bcma driver. > > OF_ADDRESS is specifically disabled for the sparc architecture. > > This results in the following error when building sparc64:allmodconfig. > > Won't this make bcma im-POSSIBLE on MIPS? And maybe x86(_64), or at > least add an unneeded dependency? I think we should somehow limit this > to BCM5301X arch. sparc, not mips. Something like "depends on !OF || OF_ADDRESS" would limit the impact to sparc, and only if OF is configured as well. I'll update accordingly and resubmit. Everything else would have to be done in the driver itself, which I rather not touch myself. Guenter