Date: Wed, 22 Oct 2014 16:15:48 +0200
From: Karl Beldan <karl.beldan@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Karl Beldan <karl.beldan@rivierawaves.com>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	Felix Fietkau <nbd@openwrt.org>
Subject: Re: [PATCH v5 0/4] add VHT support to minstrel_ht
Message-ID: <20141022141547.GB29537@magnum.frso.rivierawaves.com> (sfid-20141022_161556_365662_4D35BFA6)
References: <1413812762-6605-1-git-send-email-karl.beldan@gmail.com>
 <1413816546.32358.3.camel@jlt4.sipsolutions.net>
 <20141020151302.GB7691@magnum.frso.rivierawaves.com>
 <20141020153421.GC7691@magnum.frso.rivierawaves.com>
 <1413833597.32358.6.camel@jlt4.sipsolutions.net>
 <20141021152658.GA14839@magnum.frso.rivierawaves.com>
 <1413917246.1998.7.camel@jlt4.sipsolutions.net>
 <20141022135438.GA29537@magnum.frso.rivierawaves.com>
 <1413986851.28927.4.camel@jlt4.sipsolutions.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
In-Reply-To: <1413986851.28927.4.camel@jlt4.sipsolutions.net>
Sender: linux-wireless-owner@vger.kernel.org

On Wed, Oct 22, 2014 at 04:07:31PM +0200, Johannes Berg wrote:
> On Wed, 2014-10-22 at 15:54 +0200, Karl Beldan wrote:
> > On Tue, Oct 21, 2014 at 08:47:26PM +0200, Johannes Berg wrote:
> > > On Tue, 2014-10-21 at 17:26 +0200, Karl Beldan wrote:
> > > 
> > > > I still don't know why I don't see the smatch array warnings here, I
> > > > guess I'll live with that for now.
> > > 
> > > I'm hoping Dan will eventually pick up on it ;-)
> > > 
> > smatch is good, I get your warnings now when unsetting
> > MAC80211_RC_MINSTREL_VHT. I did not click until after checking
> > checking smatch's check_overflow.c, when there's a use after check, it
> > only barks when the indexes checked are out of bounds.
> 
> Wait, are you saying it *is* out of bounds when VHT isn't turned on?
> 

The smatch warning pops on
{
if (!(mi->groups[i].supported & BIT(j)))
	continue;
	...
else if (i >= MINSTREL_VHT_GROUP_0)
}

MINSTREL_VHT_GROUP_0 is out of bonds (not i which remains <
ARRAY_SIZE(mi->groups)).

 
Karl