Return-path: Received: from mail-lb0-f170.google.com ([209.85.217.170]:35019 "EHLO mail-lb0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751124AbaJLLkH (ORCPT ); Sun, 12 Oct 2014 07:40:07 -0400 Received: by mail-lb0-f170.google.com with SMTP id u10so5220237lbd.29 for ; Sun, 12 Oct 2014 04:40:05 -0700 (PDT) From: Rickard Strandqvist To: Brett Rudley , Arend van Spriel , linville@tuxdriver.com Cc: Rickard Strandqvist , Hante Meuleman , Pieter-Paul Giesberts , Daniel Kim , linux-wireless@vger.kernel.org, brcm80211-dev-list@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] brcmfmac: dhd_sdio.c: Cleaning up missing null-terminate in conjunction with strncpy Date: Sun, 12 Oct 2014 13:42:13 +0200 Message-Id: <1413114134-18044-1-git-send-email-rickard_strandqvist@spectrumdigital.se> (sfid-20141012_134046_621339_853EB178) Sender: linux-wireless-owner@vger.kernel.org List-ID: Now when I did the patch again I just want to ensure that this is not any other errors. Although strncpy use before was wrong, it did filled the remaining part of the string with null characters. This is not something that is needed? And a part that is not obvious right, so check. When brcmf_firmware_path[0] == '\0' we do not want to do like. if (brcmf_firmware_path[0] != '\0') { ... } else { sdiodev->fw_name[0] = '\0'; sdiodev->nvram_name[0] = '\0'; } Kind regards Rickard Strandqvist Rickard Strandqvist (1): net: wireless: brcm80211: brcmfmac: dhd_sdio.c: Cleaning up missing null-terminate in conjunction with strncpy drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c | 25 ++++++++++---------- 1 file changed, 12 insertions(+), 13 deletions(-) -- 1.7.10.4