Return-path: Received: from mail-yh0-f52.google.com ([209.85.213.52]:49911 "EHLO mail-yh0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753658AbaJWS2N (ORCPT ); Thu, 23 Oct 2014 14:28:13 -0400 Message-ID: <5449485B.4040903@gmail.com> (sfid-20141023_202833_839355_388F70C9) Date: Thu, 23 Oct 2014 16:26:35 -0200 From: Murilo Opsfelder Araujo MIME-Version: 1.0 To: Larry Finger , linville@tuxdriver.com CC: linux-wireless@vger.kernel.org, troy_tan@realsil.com.cn, netdev@vger.kernel.org, Mike Galbraith , Thadeu Cascardo Subject: Re: [PATCH V3.18] rtlwifi: Add check for get_btc_status callback References: <1414081629-23002-1-git-send-email-Larry.Finger@lwfinger.net> In-Reply-To: <1414081629-23002-1-git-send-email-Larry.Finger@lwfinger.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 10/23/2014 02:27 PM, Larry Finger wrote: > Drivers that do not use the get_btc_status() callback may not define a > dummy routine. The caller needs to check before making the call. > > Signed-off-by: Larry Finger > Cc: Murilo Opsfelder Araujo > Cc: Mike Galbraith > Cc: Thadeu Cascardo > --- > > John, > > This missing statement is causing kernel crashes for several of the drivers. > This patch should be applied ASAP. > > Larry > --- > > drivers/net/wireless/rtlwifi/pci.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/rtlwifi/pci.c b/drivers/net/wireless/rtlwifi/pci.c > index 667aba8..25daa87 100644 > --- a/drivers/net/wireless/rtlwifi/pci.c > +++ b/drivers/net/wireless/rtlwifi/pci.c > @@ -1796,7 +1796,8 @@ static int rtl_pci_start(struct ieee80211_hw *hw) > rtl_pci_reset_trx_ring(hw); > > rtlpci->driver_is_goingto_unload = false; > - if (rtlpriv->cfg->ops->get_btc_status()) { > + if (rtlpriv->cfg->ops->get_btc_status && > + rtlpriv->cfg->ops->get_btc_status()) { > rtlpriv->btcoexist.btc_ops->btc_init_variables(rtlpriv); > rtlpriv->btcoexist.btc_ops->btc_init_hal_vars(rtlpriv); > } > Hi, Larry. I've applied this patch on top of next-20141023 and my system still crashes (perhaps at a point after .get_btc_status is called). I'm not sure how to capture the panic message in text plain so I took a photo of it: http://opsfelder.com/~murilo/lkml/next-20141023_plus_larry_patch.jpg -- Murilo