Return-path: Received: from s3.sipsolutions.net ([5.9.151.49]:58571 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755828AbaJIPWX (ORCPT ); Thu, 9 Oct 2014 11:22:23 -0400 Message-ID: <1412868141.1828.57.camel@jlt4.sipsolutions.net> (sfid-20141009_172232_089185_7934EEAB) Subject: Re: [PATCH] mac80211/trivial: fix typo in starting baserate for rts_cts_rate_idx From: Johannes Berg To: Karl Beldan Cc: linux-wireless , Karl Beldan Date: Thu, 09 Oct 2014 17:22:21 +0200 In-Reply-To: <20141009144548.GD20644@magnum.frso.rivierawaves.com> (sfid-20141009_164551_939678_070A0E89) References: <1412690018-18429-1-git-send-email-karl.beldan@gmail.com> <1412845586.1828.27.camel@jlt4.sipsolutions.net> <20141009140636.GC20644@magnum.frso.rivierawaves.com> <1412864103.1828.48.camel@jlt4.sipsolutions.net> <20141009144548.GD20644@magnum.frso.rivierawaves.com> (sfid-20141009_164551_939678_070A0E89) Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, 2014-10-09 at 16:45 +0200, Karl Beldan wrote: > > > The typo is clearly showing but the faulty behavior clearly demands more > > > detail indeed. > > > > > > It affects non-(V)HT rates and can lead to selecting an rts_cts rate > > > that is not a basic rate or way superior to the reference rate (ATM > > > rates[0] used for the 1st attempt of the protected frame data). > > > E.g, assuming the drivers register growing (bitrate) sorted > > > ieee80211_rate tables, having : > > > - rates[0].idx == d'2 and basic_rates == b'10100 > > > will select rts_cts idx b'10011 & ~d'(BIT(2)-1), i.e. 1, likewise > > > - rates[0].idx == d'2 and basic_rates == b'10001 > > > will select rts_cts idx b'10000 > > > The first is not a basic rate and the second is > rates[0]. > > > > > > I hope it clarifies things enough. > > > > Well, I'm still not sure which tree I should put it in, I guess? > > > > All I can say is that nor this faulty behavior nor the correspond fix > are likely to cause a crash (we always tx registered rates). But it's still pretty misbehaving, no? That IMHO warrants fixing and even cc stable. johannes