Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:23669 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751010AbaJWNcG (ORCPT ); Thu, 23 Oct 2014 09:32:06 -0400 From: Kalle Valo To: Felix Fietkau CC: , Subject: Re: [PATCH] ath10k: add SURVEY_INFO_IN_USE for current channel on survey References: <1413996362-44397-1-git-send-email-nbd@openwrt.org> <87k33rqmwq.fsf@kamboji.qca.qualcomm.com> <5448DF0B.2090906@openwrt.org> Date: Thu, 23 Oct 2014 16:31:59 +0300 In-Reply-To: <5448DF0B.2090906@openwrt.org> (Felix Fietkau's message of "Thu, 23 Oct 2014 12:57:15 +0200") Message-ID: <87siieq5dc.fsf@kamboji.qca.qualcomm.com> (sfid-20141023_153210_398983_4C5BE28C) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-wireless-owner@vger.kernel.org List-ID: Felix Fietkau writes: > On 2014-10-23 09:13, Kalle Valo wrote: >> Felix Fietkau writes: >> >>> Signed-off-by: Felix Fietkau >>> --- >>> drivers/net/wireless/ath/ath10k/mac.c | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c >>> index 4670930..bc440dc 100644 >>> --- a/drivers/net/wireless/ath/ath10k/mac.c >>> +++ b/drivers/net/wireless/ath/ath10k/mac.c >>> @@ -3975,6 +3975,9 @@ static int ath10k_get_survey(struct ieee80211_hw *hw, int idx, >>> >>> survey->channel = &sband->channels[idx]; >>> >>> + if (ar->rx_channel == survey->channel) >>> + survey->filled |= SURVEY_INFO_IN_USE; >>> + >> >> Why? Does this fix a visible bug? What changes from user space point of >> view? I'm asking because I want to add something to the commit log. > > When user space requests survey info, it is useful to know which of the > survey data refers to the channel that is currently actively being used. > One of the use cases is getting the current channel noise for status output. > Without this flag you would have to look up the channel separately and > then compare it against the frequency in the survey output in user space. Perfect, thanks. I added this to the commit log in ath-next-test: commit f7528c6fca1b2ee1899069f1066012f47586a0c8 Author: Felix Fietkau Date: Wed Oct 22 18:46:02 2014 +0200 ath10k: add SURVEY_INFO_IN_USE for current channel on survey When user space requests survey info, it is useful to know which of the survey data refers to the channel that is currently actively being used. One of the use cases is getting the current channel noise for status output. Without this flag you would have to look up the channel separately and then compare it against the frequency in the survey output in user space. Signed-off-by: Felix Fietkau Signed-off-by: Kalle Valo -- Kalle Valo