Return-path: Received: from mail-oi0-f50.google.com ([209.85.218.50]:63244 "EHLO mail-oi0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751713AbaK3EbP (ORCPT ); Sat, 29 Nov 2014 23:31:15 -0500 Message-ID: <547A9D91.9080406@lwfinger.net> (sfid-20141130_053123_655612_4B298465) Date: Sat, 29 Nov 2014 22:31:13 -0600 From: Larry Finger MIME-Version: 1.0 To: nick CC: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: Non Explained TODOs in halbtcoutsrc.c References: <547A581A.7040609@gmail.com> In-Reply-To: <547A581A.7040609@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 11/29/2014 05:34 PM, nick wrote: > Greetings Larry, > After reading the code around the TODOS, I can't understand you reasoning for them in this file as they seem to > unneeded as the logic for the switch statement with them seems to be fine. If there are reasons for them in this > file, it would be nice to hear from you on why they are needed as TODO as a comment is rather unclear for anybody > reading this file. > Nick I did not write that code. I merely make it available through the git repo, and modify it so that it will build on all kernel versions. I do not understand the TODOs any more than you do. Larry